Skip to content

[PM-25691] Create OrganizationUpdateCollectionManagementCommand#7682

Merged
r-tome merged 8 commits into
mainfrom
ac/pm-25691/create-updatecollectionmanagementsettings-command
May 27, 2026
Merged

[PM-25691] Create OrganizationUpdateCollectionManagementCommand#7682
r-tome merged 8 commits into
mainfrom
ac/pm-25691/create-updatecollectionmanagementsettings-command

Conversation

@r-tome

@r-tome r-tome commented May 20, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25691

📔 Objective

Lift and shift the method UpdateCollectionManagementSettingsAsync from OrganizationService into a new command.

r-tome added 5 commits May 20, 2026 15:47
…terface for managing organization collection settings

* Add UpdateCollectionManagementSettingsCommand to handle updates to organization collection management settings.
* Create IUpdateCollectionManagementSettingsCommand interface to define the update method.
* Implement unit tests for UpdateCollectionManagementSettingsCommand to verify event logging and exception handling.
* Register IUpdateCollectionManagementSettingsCommand and its implementation, UpdateCollectionManagementSettingsCommand, in the service collection for managing organization collection settings.
…nagementCommand

* Added IOrganizationUpdateCollectionManagementCommand to the OrganizationsController for managing collection settings updates.
* Updated the constructor to inject the new command and modified the PutCollectionManagement method to utilize it.
* Adjusted unit tests to reflect the changes in the command used for updating collection management settings.
…eCollectionManagementSettingsAsync method

* Removed the UpdateCollectionManagementSettingsAsync method from IOrganizationService and its implementation in OrganizationService.
* Cleaned up unused usings related to collection management settings in both service files.
* Updated unit tests to reflect the removal of the collection management settings update functionality.
@r-tome r-tome added the ai-review Request a Claude code review label May 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

@r-tome r-tome changed the title Ac/pm 25691/create updatecollectionmanagementsettings command [PM-25691] Create OrganizationUpdateCollectionManagementCommand command May 20, 2026
@r-tome r-tome marked this pull request as ready for review May 20, 2026 15:04
@r-tome r-tome requested a review from a team as a code owner May 20, 2026 15:04
@r-tome r-tome requested a review from JaredScar May 20, 2026 15:04
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.52%. Comparing base (81bec7c) to head (0635aaf).

Files with missing lines Patch % Lines
...s/OrganizationUpdateCollectionManagementCommand.cs 93.65% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7682   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files        2139     2140    +1     
  Lines       94613    94628   +15     
  Branches     8462     8462           
=======================================
+ Hits        57261    57276   +15     
  Misses      35346    35346           
  Partials     2006     2006           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@r-tome r-tome changed the title [PM-25691] Create OrganizationUpdateCollectionManagementCommand command [PM-25691] Create OrganizationUpdateCollectionManagementCommand May 21, 2026
@r-tome r-tome added needs-qa and removed ai-review Request a Claude code review labels May 21, 2026
@sonarqubecloud

Copy link
Copy Markdown

@r-tome r-tome removed the needs-qa label May 26, 2026
@r-tome r-tome merged commit 705995d into main May 27, 2026
62 of 64 checks passed
@r-tome r-tome deleted the ac/pm-25691/create-updatecollectionmanagementsettings-command branch May 27, 2026 13:10
@djsmith85 djsmith85 added the t:tech-debt Change Type - Tech debt label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:tech-debt Change Type - Tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants